Skip to content

update OWNERS.md and add release guide in README.md #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2021
Merged

update OWNERS.md and add release guide in README.md #22

merged 2 commits into from
Feb 3, 2021

Conversation

@neolit123
Copy link
Member

@neolit123 neolit123 commented Jan 28, 2021 •
edited
Loading

first commit is an OWNERS update:

remove approvers to sync with kubernetes/kubernetes#98547

please state if you object to these changes.
applying lazy consensus next week ~4th of Feb.

@KentaTada i think you are not a member of the kubernetes github org?
if so, i'd be happy to sponsor your membership. likely @odinuge can +1 as well.

https://github.com/kubernetes/community/blob/master/community-membership.md#requirements
it requires sending a PR to k/org.

second commit adds a small release guide to README.md.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2021
@neolit123
Copy link
Member Author

neolit123 commented Jan 28, 2021

/kind cleanup documentation
/cc @fabriziopandini
/triage accepted
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 28, 2021
@KentaTada
Copy link

KentaTada commented Jan 29, 2021

@KentaTada i think you are not a member of the kubernetes github org?
if so, i'd be happy to sponsor your membership. likely @odinuge can +1 as well.

I am not a member of the kubernetes github org.
@neolit123 @odinuge Could you sponsor my membership?
kubernetes/org#2467

Thanks!

odinuge
odinuge approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KentaTada i think you are not a member of the kubernetes github org?
if so, i'd be happy to sponsor your membership. likely @odinuge can +1 as well.

Yes, I do! Already commented on your k8s/org issue. 🚀

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@neolit123
Copy link
Member Author

neolit123 commented Jan 29, 2021

ok, once kubernetes/org#2467 is closed we can proceed here. 👍

@neolit123
Copy link
Member Author

neolit123 commented Feb 2, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 2, 2021
@neolit123
Copy link
Member Author

neolit123 commented Feb 2, 2021

kubernetes/org#2467

merged, looking for LGTM again.
instead of removing the old approvers moved them to "emeritus_approvers"

@odinuge
Copy link
Member

odinuge commented Feb 2, 2021

/lgtm

Not sure if you want me to put it into tide now... But feel free to cancel hold if that was what you wanted! 🎉
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KentaTada
Copy link

KentaTada commented Feb 3, 2021

Thank you for all your help.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit ec744eb into kubernetes:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@timothysc timothysc Awaiting requested review from timothysc

1 more reviewer

@odinuge odinuge odinuge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odinuge odinuge

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neolit123 @KentaTada @odinuge @k8s-ci-robot